Allow custom modloader versions for auto curseforge #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2025
itzg
reviewed
Nov 14, 2025
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks! Just wondering about combining.
src/main/java/me/itzg/helpers/curseforge/InstallCurseForgeCommand.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Updated to use a single option rather than loader specific ones |
itzg
approved these changes
Nov 22, 2025
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Sorry, I probably annoyed you with all my nitpicks. Merging now so it can be included in the image and chart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--fabric-loader-version,--forge-version, and--neoforge-versionoptions to override modpack-declared modloader versions forinstall-curseforgecommand.Partial fix for itzg/docker-minecraft-server#2653
Relates to itzg/docker-minecraft-server#3759